Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field lower_is_better to the perfcompare endpoint #7852

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

beatrice-acasandrei
Copy link
Collaborator

@beatrice-acasandrei beatrice-acasandrei commented Oct 23, 2023

For testing please use the staging credentials locally using docker.
Here's a testing link. You can edit this link to contain other repositories and revisions.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de49725) 76.86% compared to head (b8f3c04) 76.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7852   +/-   ##
=======================================
  Coverage   76.86%   76.86%           
=======================================
  Files         538      538           
  Lines       26578    26580    +2     
  Branches     3359     3359           
=======================================
+ Hits        20429    20431    +2     
  Misses       5984     5984           
  Partials      165      165           
Files Coverage Δ
tests/webapp/api/test_perfcompare_api.py 79.61% <100.00%> (+0.13%) ⬆️
treeherder/webapp/api/performance_data.py 92.29% <ø> (ø)
treeherder/webapp/api/performance_serializers.py 96.05% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@beatrice-acasandrei beatrice-acasandrei merged commit 31fd997 into master Oct 25, 2023
1 check passed
@beatrice-acasandrei beatrice-acasandrei deleted the perfcompare-api-add-lower_is_better branch October 25, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants